---
title: "Discussion on \"A guide to Pull Requests\" | Hashnode"
description: "Discussion on \"A guide to Pull Requests\". Authoring and reviewing pull requests with quality and efficiency."
url: "https://hashnode.com/posts/a-guide-to-pull-requests/6214b1f195c64c6eda456446"
---

[Feed](https://hashnode.com/feed) /

Discussion

# [A guide to Pull Requests](https://tigerabrodi.blog/a-guide-to-pull-requests?utm_source=hashnode&utm_medium=feed)

Authoring and reviewing pull requests with quality and efficiency.

Feb 22, 2022 · 4 min read · tigerabrodi.blog  
Read the article

-   [#programming](https://hashnode.com/tag/programming)
-   [#general-advice](https://hashnode.com/tag/general-advice)
-   [#web-development](https://hashnode.com/tag/web-development)
-   [#webdev](https://hashnode.com/tag/webdev)
-   [#guide](https://hashnode.com/tag/guide)

## Written by

[Tiger Abrodi](https://hashnode.com/@tigerabrodi)

@tigerabrodi · Germany

  
[View profile](https://hashnode.com/@tigerabrodi)

Obsessed with crafting software.

Just a guy who loves to write code and watch anime.

## Responses 2

Markdown supported · ⌘↵ to post

[Devdatta Khoche](https://hashnode.com/@devdattakhoche)

[Feb 23, 2022](https://hashnode.com/posts/a-guide-to-pull-requests/6214b1f195c64c6eda456446/comment/621623d0a03ae28fe10fd0b5)

Well written! I loved the way you explained it, really really well for beginners to understand. Keep it up, mate !! ✌️✌️✌️

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Feb 22, 2022](https://hashnode.com/posts/a-guide-to-pull-requests/6214b1f195c64c6eda456446/comment/621501e0e6bdf08685773e43)

Thanks for the shout! Nice article. Happy to see more code review content out there in the world.

I liked how thorough your approach is — making sure to run the tests and linters, and also double checking diffs before opening the pull request.

I also like how as a reviewer, you focus on the code itself, and not the person. This is key for building relationships with empathy.

You also touched on the soft skills of humility, open-mindedness amd willingness to share knowledge. These will be key for growth in code review, as well as other aspects of your software engineer career.

A few pieces of feedback:

-   Take a look at Slack/GitHub integration. It'll automatically post in a Slack channel when a PR is opened.
-   Looks like all review comment examples are questions. Questions are OK when the deadline is far away, but remember that they also introduce back-and-forth — this adds cycles and blocks the PR. Know when to use a question, and when to make a direct suggestion.
-   The problem with pair reviews is that the reviewer has a person explaining the code, as they reviewing it. This is not a realistic situation. In reality, a developer will be reading the codebase on their own, as they're adding features. They need to be able to understand it on their own, and if they can't, it needs adjustment. Individual, async reviews realistically simulate this.
-   If PRs are forgotten or ignored, there's a problem with the team's code review process that needs adjustment.

Overall, awesome article! Thanks for sharing your thoughts, and for the shoutout! Good to be connected with you here on Hashnode.

[Niranjan Borawake](https://hashnode.com/@niranjandb)

[Feb 23, 2022](https://hashnode.com/posts/a-guide-to-pull-requests/6214b1f195c64c6eda456446/comment/621501e0e6bdf08685773e43#reply-621633eba03ae28fe10fd2a5)

Hello [Curtis Einsmann](https://hashnode.com/@curtiseinsmann) and [Tiger Abrodi](https://hashnode.com/@tigerabrodi),

Interesting topic and discussion. I think the code review is indeed a very important topic along with unit tests.

IMO, code review has more todo with people than actual code 😆 and hence some of the examples shared above become crucial.

I had put my thoughts on similar lines a while back -

[blog.niranjanborawake.in/make-yourself-proud-by-r…](https://blog.niranjanborawake.in/make-yourself-proud-by-reviewing-pull-requests)