---
title: "Comment by OnlineProxy on \"Competitor Fares Are a Signal, Not a Pricing Strategy\" | Hashnode"
description: "the biggest risk is max_discount_ratio which filters out heavily discounted quotes. if those are mostly the cheaper ones, the remaining sample overstates the ma"
url: "https://hashnode.com/posts/competitor-fares-are-a-signal-not-a-pricing-strategy/6ad73ccddb711ef669641cbe/comment/6ad77d8625363d4998679900"
---

[Discussion](https://hashnode.com/posts/competitor-fares-are-a-signal-not-a-pricing-strategy/6ad73ccddb711ef669641cbe)

Comment [Competitor Fares Are a Signal, Not a Pricing Strategy](https://hashnode.com/posts/competitor-fares-are-a-signal-not-a-pricing-strategy/6ad73ccddb711ef669641cbe)

[OnlineProxy](https://hashnode.com/@onlineproxyio)

[Oct 20](https://hashnode.com/posts/competitor-fares-are-a-signal-not-a-pricing-strategy/6ad73ccddb711ef669641cbe/comment/6ad77d8625363d4998679900)

the biggest risk is max\_discount\_ratio which filters out heavily discounted quotes. if those are mostly the cheaper ones, the remaining sample overstates the market fare. the ratio also assumes total\_fare is gross so the filter misbehaves if the input is already net

on ETA the clearest gap is that the function can return available True with median\_eta None, which breaks the article's own coverage rule. confidence is really a sample count, and now = time() makes the output time dependent and hard to test
