---
title: "Discussion on \"Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.\" | Hashnode"
description: "Discussion on \"Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.\". Software engineers engage in code reviews daily.\nSome teams have a great code review process. Others could use improvement.\nHere are 3 signs of a bad code review process, and how your team can ship faster.\n3 signs of a bad code review process\n🚩 If c..."
url: "https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746"
---

[Feed](https://hashnode.com/feed) /

Discussion

# [Most teams are doing code reviews wrong. Here are 3 warning signs, and 3 fixes.](https://curtiseinsmann.hashnode.dev/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes?utm_source=hashnode&utm_medium=feed)

Software engineers engage in code reviews daily. Some teams have a great code review process. Others could use improvement. Here are 3 signs of a bad code review process, and how your team can ship faster. 3 signs of a bad code review process 🚩 If c...

Jan 25, 2022 · 4 min read · curtiseinsmann.hashnode.dev  
Read the article

-   [#code-review](https://hashnode.com/tag/code-review)
-   [#software-engineering](https://hashnode.com/tag/software-engineering)
-   [#soft-skills](https://hashnode.com/tag/soft-skills)
-   [#software-development](https://hashnode.com/tag/software-development)
-   [#programming](https://hashnode.com/tag/programming)

## Written by

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

@einsmanntech · VA, 🇺🇸

  
[View profile](https://hashnode.com/@einsmanntech)

Software engineer; solopreneur. Follow me on Twitter for more!

Software engineer; solopreneur. Writing to help developers level up. Follow me on Twitter for more.

## Responses 7

Markdown supported · ⌘↵ to post

[uzlopak](https://hashnode.com/@uzlopak)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f2df2b52c7824742748756)

Actually no real advice was given by this article. Also Lacks of hacker mentality. If you have a better idea on solving an issue in a PR then provide a poc or branch off and make your fixes there. The original coder can then adapt it by merging and then there is less back and forth. Or atleast provide pseudocode and/or offer pair programming.

I already had cases, where the team thought a solution was good enough, despite my "nitpicking". I finally branched off, added a poc exploit and branched again off and fixing it properly...

Last advice has to be, like Aristotle already wrote, if you have somebody, who is not able to discuss, than don't discuss with him. It means in our world, to leave the team or maybe the company.

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f2df2b52c7824742748756#reply-61f2fcc522a38747671d6f6d)

The article specifically calls out 3 things that should be documented in the code review guidelines. If they were unclear, I’m open to suggestions on how they can be clarified.

A code reviewer isn’t expected to fix the author’s code. They’re reviewing, not doing the work for them.

[Cathal Mac Donnacha](https://hashnode.com/@cathalmacdonnacha)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f27f208a9bc14421f57d7c)

Great article. Shameless plug but I actually [wrote an article](https://cathalmacdonnacha.com/6-tips-every-code-review-author-should-know) outlining some tips from a code review author's point of view, which touches on some of the same points.

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f27f208a9bc14421f57d7c#reply-61f2fd4752c7824742748a1e)

Thanks for sharing! Respectfully though, I don’t see where they touch in the same points, other than the fact they’re both about PRs.

[Victoria Lo](https://hashnode.com/@victoria)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f1f574e247b2151e6226b6)

Thanks for sharing this informative article :) Communication is definitely key to ensuring an efficient and healthy code review environment.

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f1f574e247b2151e6226b6#reply-61f21484805bdf3ebd48628c)

Happy to share! Thanks for reading. 😄

[Prafful Lachhwani](https://hashnode.com/@Prafful)

[Jan 26, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f151f887fd2728e7cd5ae7)

Great article! I would share this with my reviewer LOL

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 27, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f151f887fd2728e7cd5ae7#reply-61f2147087fd2728e7cd7075)

Please do!

[Tomasz Gil](https://hashnode.com/@tomaszgil)

[Jan 25, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f0691687fd2728e7cd422a)

Nice one [Curtis Einsmann](https://hashnode.com/@curtiseinsmann)! Great advice - I definitely agree with you on these points. 👏

I always new that code review is sensitive matter, but only today it occurred to me why that is - it all revolves around creating and resolving disagreements.

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 26, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f0691687fd2728e7cd422a#reply-61f0d525e247b2151e6203b1)

Yes it’s a daily process where there’s a lot of opportunity for improvement in many teams. Thanks for reading!

[Braydon Coyer](https://hashnode.com/@braydoncoyer)

[Jan 25, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f06843e247b2151e61fa60)

Great content, Curtis! It’s not uncommon to see these unhealthy code reviews on the job. Thankfully, we can all do our part to try and change the feeling and effectiveness, and promote a healthier culture.

[Curtis Einsmann](https://hashnode.com/@einsmanntech)

[Jan 26, 2022](https://hashnode.com/posts/most-teams-are-doing-code-reviews-wrong-here-are-3-warning-signs-and-3-fixes/61f0512ae247b2151e61f746/comment/61f06843e247b2151e61fa60#reply-61f0d4eb87fd2728e7cd4ac0)

Well said. Thanks Braydon! 💯
