Sign in
Log inSign up
Curtis Einsmann

167 likes

·

3.2K reads

19 comments

Apoorv Tyagi
Apoorv Tyagi
Nov 10, 2020

That is an awesome article Curtis Einsmann, you made some really good points

And congrats on getting your first article featured on hashnode :)

3
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 10, 2020

Thanks Apoorv! Appreciate the kind words.

·
Chris Bongers
Chris Bongers
Nov 11, 2020

Nice one,

So when you approve with comments do you get a lot of people who actually go and fix them anyway?

I tend to do this, just to learn from the reviewer, was wondering if many people do that.

2
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 11, 2020

Depends on the developer.

When my teammates approve my authored PR's with comments, I always address them before a merge. But I don't hold a grudge against my teammates if they don't do the same.

1
·
Catalin Pit
Catalin Pit
Nov 10, 2020

Hey, nice article!

Also, happy to see you here. :-)

1
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 10, 2020

Thanks Catalin! Good to see you here, too. =)

1
·
Braydon Coyer
Braydon Coyer
Nov 10, 2020

Excellent read. I'd be interested to hear how unit tests play into your review process, if at all.

1
·
·2 replies
Curtis Einsmann
Curtis Einsmann
Author
·Nov 10, 2020

Thank you Braydon! Unit tests are included within the PR in most cases. Same principles apply for the most part. Sometimes the author can indicate what the test coverage is.

2
·
Braydon Coyer
Braydon Coyer
Nov 10, 2020

Curtis Einsmann Awesome - thanks for replying!

1
·
Mario Cervera
Mario Cervera
Nov 10, 2020

Great article Curtis!

You make some great points.

I specially liked the ones about encouraging a high code quality bar and design principles being guidelines, not rules.

1
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 10, 2020

Thanks Mario! Yes, it's important to keep this in mind. We must acknowledge that subjectivity that comes with code preferences.

1
·
Jay Desai
Jay Desai
Nov 11, 2020

Awesome Article Curtis Einsmann!

I liked the way you measure PR's with kindness...!

1
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 11, 2020

Thanks, Jay! That's the most important point here. 😄

1
·
Shad Mirza
Shad Mirza
Nov 11, 2020

This was a great article. Thank you for sharing your experience. Bookmarked !!

1
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Nov 11, 2020

Absolutely. Happy you liked it!

·
Junaid Ahmad
Junaid Ahmad
Jan 27, 2022

Amazing and insightful article.

1
·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Jan 27, 2022

Thanks for reading!

·
Kiran K
Kiran K
Oct 22, 2021

A very good article about the PR review.

·
·1 reply
Curtis Einsmann
Curtis Einsmann
Author
·Oct 22, 2021

Thanks for reading, Kiran!

·