- It's code, you can think of it as art but in the end it needs structure.
- first review functional, after that review code-styles -> nothing annoys more than formatting the code 3 times and get an "obvious" logic error that has been there before.
- try to keep in mind: taste != right -> we all have different styles and approaches to solutions. if I review something and I don't like the style. I will mention it + why I would do it otherwise or even read up on it and ask why it was implemented that way, but that's it.
- Always stick to constructive criticism. put simple: don't just complain over it, add some feedback + a solution
- try to use a code-formatter or something that eliminates useless bracket or whatever discussions. We don't want waste time with superficial discussions or updating a "coding standard" wiki page that will be opened 1 time ;D ...
- appreciate nice solutions ! don't forget we all need positive feedback as well.
That at least how I review the code of my colleagues.
[has been edited]