Popular posts

We use GitHub enterprise on my team and we have pull requests for every change. Two developers who are familiar with the code are required to review and approve pull requests. Depending on the size and complexity of the pull request, we may ask more folks to look at it and some may even pull it down to their local machine to manually test the experience. For UI changes we'll often include a before/after screenshot or gif to make the review process easier :)

Our team's code review process is mostly similar to Kent Dodds. We take advantage of GitHub's Pull Request Templates to ensure our developers fill in the right details of their change. These vary across projects, but generally include:

1. Problem
2. Solution
3. Verification (screenshots, or steps the submitter did to reproduce the issue)
4. Concerns
5. Relevant links
6. Required reviewers

Naturally some changes don't require this much paperwork, and only number 1, 2, are 6 mandatory. For simple or focused projects, we may require only one code reviewer.