Comment by Astha Srivastava on "How do you work with pull requests at work?"

Hi Ivan, I follow same approach but in different way. I am using MS Teams for PR review. These are the steps:

We have two teams of developer, let's name them "ABC" and "XYZ" who review and approve the PR.
Once we create PR, notification goes to both the teams "ABC" and "XYZ" via email or we copy the link and send it to respective developer for review and approval of PR.
Anyone from the team can review and approve the PR but both the team approval is needed.
Once the approval is done, there will be a green tick mark on both the teams name that your PR is approved.
After that you can complete your PR and then it will merge the PR to the branch.

Hi Astha, thank you for such detailed answer! It looks like the described flow works quite well for you. Is there any part of the process that you find inconvenient or annoying?

I've never used MS Teams so it's hard for me to understand some of the specifics. Hope you don't mind a couple clarifying questions:

Once we create PR, notification goes to both the teams "ABC" and "XYZ" via email or we copy the link and send it to respective developer for review and approval of PR.

Does it always work well for you? Do you ever need to remind people about reviewing a PR? Does that "PR email" ever get lost between other mail people receive. Does MS Teams send these notification automatically?

Once the approval is done, there will be a green tick mark on both the teams name that your PR is approved.

Is this green marking a feature of MS Teams product?

Thank you!

Ivan Bokii Is there any part of the process that you find inconvenient or annoying? I feel this is the easiest process and till now I have not faced any issues. So yes, it works well for me.

You even have the option to auto-complete your PR(MS team feature). When the review is done by both the teams, it will complete your PR and merges the source branch to the target branch.

"PR email" --> yes it sometimes gets missed.. but I generally don't follow the e-mail process. I use the link and send it to the respective developer for review and approval. That solves the issue of missing out on any PR.

Is this green marking a feature of MS Teams product? Yes, this is a feature of MS Teams.

Search Hashnode