Discussion

Code Smell 188 - Redundant Parameter Names

Use contextual and local names

Written by

Maxi Contieri

@mcsee · Buenos Aires

Software Engineer

I’m a senior software engineer loving clean code, and declarative designs. S.O.L.I.D. and agile methodologies fan.

Markdown supported · ⌘↵ to post

Syed Jafer K

Nice one. I feel it will also apply to instance variables,

class Employee:
    def __init__(self):
        self.employee_first_name = ''

to this,

class Employee:
    def __init__(self):
        self.first_name = ''