Naming the verdict file after the commit hash is the detail I would point other people to. It closes the most common hole in AI review setups, where an ACCEPT from an earlier commit quietly covers code nobody reviewed.
Step 2 deserves the most attention. Rules that name something visible in a diff and say how to check it are what turn review into findings instead of opinions, and the same idea works one level up. On client projects we write the finish line for the whole task in that style before the writer starts: what must work, what must stay exactly as it is, and how it will be checked. Then the reviewer has both the rulebook and the task's definition of done.
Your gate proves the steps happened, as you say, not that the code is correct. Have you tried giving Codex the task's acceptance criteria as well as the diff, and did it catch different things?
Thanks, and yes, the commit hash in the file name exists for exactly that reason. An old ACCEPT should never cover code that came after it.
On acceptance criteria: yes, that's where I took it next. Each change now starts with a short "Done means" list, and Codex has to mark every line met, not met or not checkable, with the house rules checked the same way. [your sentence here]
I wrote that part up on my website blog but.. cant post links yet..
Naming the verdict file after the commit hash is the detail I would point other people to. It closes the most common hole in AI review setups, where an ACCEPT from an earlier commit quietly covers code nobody reviewed.
Step 2 deserves the most attention. Rules that name something visible in a diff and say how to check it are what turn review into findings instead of opinions, and the same idea works one level up. On client projects we write the finish line for the whole task in that style before the writer starts: what must work, what must stay exactly as it is, and how it will be checked. Then the reviewer has both the rulebook and the task's definition of done.
Your gate proves the steps happened, as you say, not that the code is correct. Have you tried giving Codex the task's acceptance criteria as well as the diff, and did it catch different things?