Feed
uzlopak
Great article. Shameless plug but I actually wrote an article outlining some tips from a code review author's point of view, which touches on some of the same points.
Thanks for sharing this informative article :) Communication is definitely key to ensuring an efficient and healthy code review environment.
Great article! I would share this with my reviewer LOL
Nice one Curtis Einsmann! Great advice - I definitely agree with you on these points. 👏
I always new that code review is sensitive matter, but only today it occurred to me why that is - it all revolves around creating and resolving disagreements.
Great content, Curtis! It’s not uncommon to see these unhealthy code reviews on the job. Thankfully, we can all do our part to try and change the feeling and effectiveness, and promote a healthier culture.
Actually no real advice was given by this article. Also Lacks of hacker mentality. If you have a better idea on solving an issue in a PR then provide a poc or branch off and make your fixes there. The original coder can then adapt it by merging and then there is less back and forth. Or atleast provide pseudocode and/or offer pair programming.
I already had cases, where the team thought a solution was good enough, despite my "nitpicking". I finally branched off, added a poc exploit and branched again off and fixing it properly...
Last advice has to be, like Aristotle already wrote, if you have somebody, who is not able to discuss, than don't discuss with him. It means in our world, to leave the team or maybe the company.