Giovanni Benussi Paredes

May 17, 2017

What about this:

foreach($products as $product) {
  process(product);
}

if (somecondition) {
  foreach($products as $product) {
    doSomething(product);
  }
}

This way you instantly know that if somecondition is true, doSomething will be executed on each product (I think that this is subtle, but useful) and also you don't have to ask for somecondition every time in the foreach loop.

K L Bhanu

Student

May 17, 2017

IMHO, this may not work always, what if somecondition is applicable to array elements?

Giovanni Benussi Paredes

May 17, 2017

Sorry, what do you mean with that?

K L Bhanu

Student

May 17, 2017

i meant what if dosomething is to be applied to only a part of the array elements ( $products)? (sorry a typo in the above post)

Giovanni Benussi Paredes

May 17, 2017

That could only happen if somecondition changed after executing process(product) . But that's right.. it depends if it does that or not!

Also, if we have to make a change after call process , why not trigger it automatically? That's more a design decision and it depends on other factors (e.g: this only needs to be done in some controller and not in all of them).

And last, I think that if you have the code that Ovidiu Bădiță proposed, maybe this could be encapsulated in a correctly named function and there would not be a big problem because with a great name you don't have to worry TOO MUCH if the code can't be refactored in a more concise way.

Search Hashnode