Comment by Mark on "How do you perform a code review?"

CommentHow do you perform a code review?

Mark

formerly known as M

Oct 10, 2018

At work, I use a code review tool, without pulling in the code except in special cases. We have testers who will verify that it works; the review is mostly for conventions, code quality, architecture, seeing if things make sense... If it needs running the code, it's the job of the developer and the tester.

For open source projects, I don't have testers, so I more often pull the code to test locally. This is besides using the code review interface of Github / Bitbucket.

Perhaps if I'm ever in charge of this choice, I'd look for a code review tool with good IDE integration. I'd like to test code and leave comments without leaving the IDE.

Riderman de Sousa Barbosa

Frontend Developer

Oct 16, 2018

The problem with only use the review tool .. is that you are limited to online tool.

How can you make sure the CSS is working, or the the code quality was followed since you are reviewing just the line changes or even worst, how to approve one pull request if you do not test at least locally.

You need to keep in mind that, approve one pull request.. you are saying that this feature is ok to merge into another branch .. and this means that the feature are following code conventions, code quality and most important... is working at least happy basic path

It doesn't mean that for me. If I approve a code review, it means it's okay to be tested by the QA team. Only then is it merged.

Search Hashnode