Discussion on "PR like a Pro 😎"

Tejansh Rana · 2021-03-10T19:28:11.309Z

Before we jump into what can you do to ensure that pull requests (PRs) add value to your projects instead of being a bottleneck, let's cover the basics. What are Pull Requests? Pull requests let you tell others about changes you've pushed to a bran...

Thank you Suraj Shende! 🙂

Great article, Tejansh Rana! 👏

I enjoyed it, especially these points:

Break it down to smaller PRs against your own branch and get that reviewed.
Add all the relevant information that you can to the PR.
A suitable title for your PR can also give clarity to the reviewer before they even read the description.

Thank you Catalin Pit! 🙂

It is much better to use gitflow. datasift.github.io/gitflow/IntroducingGitFlow.html

Sorry, what is it better for?

Nandy Legorreta if you mean for git branch management, here is what the author of Gitflow has to say about it - nvie.com/posts/a-successful-git-branching-model

TL;DR: It is a 10 year old model which is no longer recommended due to various constraints and since the workflow in Github has advanced significantly since. 🙂

I really liked the idea of opening the multiple PR against the own branch for huge changes. Having gone through a migration I feel that this would have helped the team members review the PR a lot faster without loosing interest in reviewing/testing it.

Thank you Jay. This has helped us a lot and we actively follow it when working on chunkier tasks like building the boilerplate code for a new project/microservice 🙂

Can you told me about an app which you use in the main picture? Is just an image or this is the external app?

Might be gitkraken.com

Tejansh Rana - thanks ;-)

Zachary Dixon - I using gitkraken but this isn't 1:1 like on the image. On the image on the left sidebar, we have folder/file tree + main window git branches. I was hoping this is a good addon for ide ;D

I see what you mean Michał Wójcik. Yes, you get a very similar looking feature in the IDEs from JetBrains like IntelliJ where you can visualise the git flow. 🙂

Thanks for this amazing write-up! Thanks, brother 👏

Thank you Savio Martin! 🙂

Search Hashnode

PR like a Pro 😎

Responses(7)