Having an accomplishments list is great advice and very helpful. One of my previous bosses called it the 'Why I am great' folder.
Making this a habit absolutely makes performance review time easier. As you add, another helpful piece of advice is ensuring you include results and metrics.
Having that information saved could be very useful for the future as you explore new opportunities. Thanks for sharing Brett!