Comment by HEE JAE CHOI on "7 Different Ways to Flatten a List of Lists in Python" | Hashnode

HEE JAE CHOI

dev

Dec 13, 2020

Great article!!

By the way, is it typo?

def flatten_recursive(lst: List[Any]) -> Iterable[Any]:
    """Flatten a list using recursion."""
    for item in lst:
        if isinstance(item, list):
            yield from flatten(item)  # This line! I think it will be `yield from flatten_recursive(item)`
        else:
            yield item

Miguel Brito

Machine Learning Software Engineer - Hobbyst Technical Writer - Interested in Software Testing, Best Practices, Scalability, and Python.

Dec 13, 2020

Thanks HEE JAE CHOI, and yes, this is a typo!

Thanks for flagging it, I've just fixed it. I renamed it before publishing to make it easier to understand and forgot to double check it in IPython.

This is the correct version:

def flatten_recursive(lst: List[Any]) -> Iterable[Any]:
    """Flatten a list using recursion."""
    for item in lst:
        if isinstance(item, list):
            yield from flatten_recursive(item)
        else:
            yield item

Search Hashnode